Expose populateStablehloToLinalgConversionPatterns function #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function declaration has existed since the code was forked from IREE in #1817, but the implementation was kept private (static function within an anonymous namespace).
I'm now trying to switch IREE from having its own implementation to using the upstream implementation from this project in iree-org/iree#19792, and I would like to access these patterns directly, instead of through the
StablehloLegalizeToLinalgPass. With the patterns I can run conversion including my own sets of additional patterns, while a pass runs in isolation.I'm also deleting the
populateLegalizeChloPatterns,populateLegalizeControlFlowPatterns, andpopulateLegalizeShapeComputationPatternsdeclarations, which were not migrated from IREE and are also dangling without implementations.